Return-Path: <dev-return-26364-archive-asf-public=cust-asf.ponee.io@drill.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 29C57200BF7
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon,  9 Jan 2017 08:03:38 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 28512160B3E; Mon,  9 Jan 2017 07:03:38 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 67C32160B3B
	for <archive-asf-public@cust-asf.ponee.io>; Mon,  9 Jan 2017 08:03:37 +0100 (CET)
Received: (qmail 99877 invoked by uid 500); 9 Jan 2017 07:03:36 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 99866 invoked by uid 99); 9 Jan 2017 07:03:36 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Jan 2017 07:03:36 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 17CA0DFB8E; Mon,  9 Jan 2017 07:03:36 +0000 (UTC)
From: kkhatua <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-719-drill@git.apache.org>
In-Reply-To: <git-pr-719-drill@git.apache.org>
Subject: [GitHub] drill pull request #719: DRILL-5172: Display elapsed time for queries in the...
Content-Type: text/plain
Message-Id: <20170109070336.17CA0DFB8E@git1-us-west.apache.org>
Date: Mon,  9 Jan 2017 07:03:36 +0000 (UTC)
archived-at: Mon, 09 Jan 2017 07:03:38 -0000

Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/719#discussion_r95108121
  
    --- Diff: exec/java-exec/src/main/resources/rest/profile/list.ftl ---
    @@ -64,6 +65,8 @@
                 <td>
                   <div style="height:100%;width:100%">${query.getState()}</div>          
                 <td>
    +              <div style="height:100%;width:100%">${(.now?long - query.getStartTime()) / 1000} sec</div>          
    --- End diff --
    
    Good point. For long running queries, reporting in a single unit actually makes readability much harder. Modified in the next commit. Had to modify the UserBitShared class, however, to add this functionality for the query profile. Unless there is a change to the protobuf, we should be fine. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---