drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #685: Drill 5043: Function that returns a unique id per s...
Date Mon, 30 Jan 2017 10:37:45 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/685#discussion_r98414144
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ContextFunctions.java
---
    @@ -64,17 +65,45 @@ public void eval() {
         @Inject DrillBuf buffer;
         @Workspace int currentSchemaBytesLength;
     
    +    @Override
         public void setup() {
           final byte[] currentSchemaBytes = contextInfo.getCurrentDefaultSchema().getBytes();
           buffer = buffer.reallocIfNeeded(currentSchemaBytes.length);
           currentSchemaBytesLength= currentSchemaBytes.length;
           buffer.setBytes(0, currentSchemaBytes);
         }
     
    +    @Override
         public void eval() {
           out.start = 0;
           out.end = currentSchemaBytesLength;
           out.buffer = buffer;
         }
       }
    +
    +  /**
    +   * Implement "session_id" function. Returns the unique id of the current session.
    +   */
    +  @FunctionTemplate(name = "session_id", scope = FunctionTemplate.FunctionScope.SIMPLE,
isNiladic = true)
    --- End diff --
    
    Please exclude `timeofday, now, statement_timestamp, transaction_timestamp, unix_timestamp`.
Just leave those that already behave like niladic functions (just execute function in Drill
and see if it requires parenthesis or not, if not, then it's niladic :)). We don't won't to
change existing behavior not to break queries.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message