drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From parthchandra <...@git.apache.org>
Subject [GitHub] drill pull request #723: DRILL-5207: Improve Parquet Scan pipelining.
Date Sat, 28 Jan 2017 00:44:01 GMT
Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/723#discussion_r98269860
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
    @@ -74,12 +82,17 @@ protected void loadDictionaryIfExists(final ColumnReader<?>
parentStatus,
             handleAndThrowException(e, "Error Reading dictionary page.");
           }
           // parent constructor may call this method before the thread pool is set.
    -      if (threadPool == null) {
    +      if (threadPool == null & asyncPageRead == null) {
             threadPool = parentColumnReader.parentReader.getOperatorContext().getScanExecutor();
    +        queueSize  = parentColumnReader.parentReader.getFragmentContext().getOptions()
    +            .getOption(ExecConstants.PARQUET_PAGEREADER_QUEUE_SIZE).num_val;
    +        if(queueSize < 1) { // A queue with a capacity less than 1 is not cool
    --- End diff --
    
    OK


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message