drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #729: Drill 1328 r4
Date Thu, 26 Jan 2017 19:53:35 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/729#discussion_r98077612
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/NestedLoopJoinPrule.java
---
    @@ -84,8 +88,14 @@ public void onMatch(RelOptRuleCall call) {
         if (!settings.isNestedLoopJoinEnabled()) {
           return;
         }
    -
    -    final DrillJoinRel join = (DrillJoinRel) call.rel(0);
    +    int[] joinFields = new int[2];
    +    DrillJoinRel join = (DrillJoinRel) call.rel(0);
    +    // If right outer join on simply equi join convert it to left outer join. We only
support left outer NLJ as of now
    +    if (join.getJoinType() == JoinRelType.RIGHT
    --- End diff --
    
    Can you do this change as part of a separate JIRA since it is unrelated to statistics.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message