drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Serhii-Harnyk <...@git.apache.org>
Subject [GitHub] drill pull request #713: DRILL-3562: Query fails when using flatten on JSON ...
Date Tue, 24 Jan 2017 15:45:24 GMT
Github user Serhii-Harnyk commented on a diff in the pull request:

    https://github.com/apache/drill/pull/713#discussion_r97576603
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
    @@ -59,6 +59,12 @@
       private final boolean readNumbersAsDouble;
     
       /**
    +   * Collection for tracking empty array writers during reading
    +   * and storing them for initializing empty arrays
    +   */
    +  private final Set<ListWriter> emptyArrayWritersSet = Sets.newHashSet();
    --- End diff --
    
    @amansinha100 Yes, you are right, in this place should be used List. Fixed it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message