drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #666: DRILL-4956: Temporary tables support
Date Mon, 23 Jan 2017 20:58:39 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/666#discussion_r97414070
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
---
    @@ -62,9 +62,10 @@ public PhysicalPlan getPlan(SqlNode sqlNode) throws ValidationException,
RelConv
     
           final String newViewName = createView.getName();
     
    +      // Disallow temporary tables usage in view definition
    +      config.getConverter().disallowTemporaryTables();
    --- End diff --
    
    Looks like we only disable temporary tables in create view flow? What about view expansion
logic? 
    
    Let's say under "dfs.tmp", I have a temporary table "t1" which is masked into what_ever_random_name,
and I also have folder "t1" for a regular table "t1".  When we create a view on top of "t1",
since temporary table is disabled, we will resolve to this regular table "t1". However, when
we run a query against a view, do we resolve to the temporary table in stead? Is this what
we expect to see?
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message