drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #710: DRILL-5126: Provide simplified, unified "cluster fi...
Date Thu, 19 Jan 2017 03:24:11 GMT
Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/710#discussion_r96785539
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/QueryBuilder.java ---
    @@ -57,20 +166,36 @@
         private final int records;
         private final int batches;
         private final long ms;
    +    private final QueryState finalState;
    +    private final Exception error;
     
    -    public QuerySummary(QueryId queryId, int recordCount, int batchCount, long elapsed)
{
    +    public QuerySummary(QueryId queryId, int recordCount, int batchCount, long elapsed,
QueryState state) {
           this.queryId = queryId;
           records = recordCount;
           batches = batchCount;
           ms = elapsed;
    +      finalState = state;
    +      error = null;
         }
     
    -    public long recordCount( ) { return records; }
    -    public int batchCount( ) { return batches; }
    -    public long runTimeMs( ) { return ms; }
    -    public QueryId queryId( ) { return queryId; }
    -    public String queryIdString( ) { return QueryIdHelper.getQueryId(queryId); }
    +    public QuerySummary(QueryId queryId, int recordCount, int batchCount, long elapsed,
Exception ex) {
    +      this.queryId = queryId;
    +      records = recordCount;
    +      batches = batchCount;
    +      ms = elapsed;
    +      finalState = null;
    +      error = ex;
    +    }
     
    +    public boolean failed() { return error != null; }
    +    public boolean succeeded() { return error == null; }
    --- End diff --
    
    formatting here ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message