drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #685: Drill 5043: Function that returns a unique id per s...
Date Tue, 17 Jan 2017 17:23:37 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/685#discussion_r96446816
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/ContextInformation.java
---
    @@ -28,12 +28,14 @@
       private final String currentDefaultSchema;
       private final long queryStartTime;
       private final int rootFragmentTimeZone;
    +  private final String sessionId;
     
    -  public ContextInformation(final UserCredentials userCredentials, final QueryContextInformation
queryContextInfo) {
    +  public ContextInformation(UserCredentials userCredentials, final QueryContextInformation
queryContextInfo) {
    --- End diff --
    
    Any particular reason to remove final for one param but leave for another? I guess you
can just leave it as it was before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message