drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #581: DRILL-4864: Add ANSI format for date/time functions
Date Thu, 12 Jan 2017 21:28:19 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/581#discussion_r95865424
  
    --- Diff: exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/SqlToDateTypeFunctions.java
---
    @@ -0,0 +1,77 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +import org.apache.drill.exec.expr.annotations.Workspace;
    +
    +<@pp.dropOutputFile/>
    +
    +<#list dateIntervalFunc.dates as type>
    +
    +<@pp.changeOutputFile name = "/org/apache/drill/exec/expr/fn/impl/SqlTo${type}.java"/>
    +
    +<#include "/@includes/license.ftl"/>
    +
    +package org.apache.drill.exec.expr.fn.impl;
    +
    +import org.apache.drill.exec.expr.DrillSimpleFunc;
    +import org.apache.drill.exec.expr.annotations.FunctionTemplate;
    +import org.apache.drill.exec.expr.annotations.FunctionTemplate.NullHandling;
    +import org.apache.drill.exec.expr.annotations.Output;
    +import org.apache.drill.exec.expr.annotations.Workspace;
    +import org.apache.drill.exec.expr.annotations.Param;
    +import org.apache.drill.exec.expr.holders.*;
    +
    +/*
    + * This class is generated using freemarker and the ${.template_name} template.
    + */
    +
    +@FunctionTemplate(name = "sql_to_${type?lower_case}",
    +                  scope = FunctionTemplate.FunctionScope.SIMPLE,
    +                  nulls = NullHandling.NULL_IF_NULL)
    +public class SqlTo${type} implements DrillSimpleFunc {
    +
    +    @Param  VarCharHolder left;
    +    @Param  VarCharHolder right;
    +    @Workspace org.joda.time.format.DateTimeFormatter format;
    +    @Output ${type}Holder out;
    +
    +    public void setup() {
    +        // Get the desired output format
    +        byte[] buf = new byte[right.end - right.start];
    +        right.buffer.getBytes(right.start, buf, 0, right.end - right.start);
    +        String formatString = new String(buf, com.google.common.base.Charsets.UTF_8);
    --- End diff --
    
    While this code is perfectly fine, I would recommend we move it elsewhere as we use it
over and over again, and there is only one right way to extract a string from a VarChar vector.
Perhaps this should appear in the VarCharVector.Accessor class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message