drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #716: DRILL-5116: Enable generated code debugging in each...
Date Tue, 10 Jan 2017 19:46:37 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/716#discussion_r95442239
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java
---
    @@ -141,7 +142,9 @@ public ClassBuilder(DrillConfig config, OptionManager optionManager)
{
         // A key advantage of this method is that the code can be
         // saved and debugged, if needed.
     
    -    saveCode(code, name);
    +    if (cg.persistCode()) {
    --- End diff --
    
    Sounds to me that `persistCode(boolean)` is to set the persist boolean flag in code generator
if it's allowed, while `persistCode()` is to check if the boolean flag is turned on or not.
In such case, can we call the former as `setPersistMode(boolean)`, and call the later as `isPersistable`?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message