drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #719: DRILL-5172: Display elapsed time for queries in the...
Date Mon, 09 Jan 2017 07:03:36 GMT
Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/719#discussion_r95108121
  
    --- Diff: exec/java-exec/src/main/resources/rest/profile/list.ftl ---
    @@ -64,6 +65,8 @@
                 <td>
                   <div style="height:100%;width:100%">${query.getState()}</div>
         
                 <td>
    +              <div style="height:100%;width:100%">${(.now?long - query.getStartTime())
/ 1000} sec</div>          
    --- End diff --
    
    Good point. For long running queries, reporting in a single unit actually makes readability
much harder. Modified in the next commit. Had to modify the UserBitShared class, however,
to add this functionality for the query profile. Unless there is a change to the protobuf,
we should be fine. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message