drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #716: DRILL-5116: Enable generated code debugging in each...
Date Sat, 07 Jan 2017 01:09:48 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/716#discussion_r95040108
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestConvertFunctions.java
---
    @@ -76,6 +75,22 @@
     
       String textFileContent;
     
    +  @BeforeClass
    +  public static void setup( ) {
    +    // Tests here rely on the byte-code merge approach to code
    +    // generation and will fail if using plain-old Java.
    +    // Actually, some queries succeed with plain-old Java that
    +    // fail with scalar replacement, but the tests check for the
    +    // scalar replacement failure and, not finding it, fail the
    +    // test.
    +    //
    +    // The setting here forces byte-code merge even if the
    +    // config file asks for plain-old Java.
    +    // TODO: Fix the tests to handle both cases.
    +
    +    System.setProperty("drill.compile.prefer_plain_java", "false");
    --- End diff --
    
    Same as above comment. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message