drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #716: DRILL-5116: Enable generated code debugging in each...
Date Sat, 07 Jan 2017 01:09:48 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/716#discussion_r95046588
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -167,10 +167,12 @@ drill.exec: {
         debug: true,
         janino_maxsize: 262144,
         cache_max_size: 1000,
    -    // Enable to write generated source to disk. See ClassBuilder
    -    save_source: false,
         // Where to save the generated source. See ClassBuilder
         code_dir: "/tmp/drill/codegen"
    --- End diff --
    
    Writing to an external directory may require to add such source directory to the IDE project
each time when people try to debug the generated code. 
    
    One way I tried is to put the generated source under $drill-java-exec/target/generated-sources,
which is currently for freemarker's generated source.  That way, Intellij is able to load
these new generated class automatically when you debug. 
    
    The above approach requires us to exclude those runtime generated class from the distribution
jars, by adding the following in java-exec pom.xml. 
    
    ```
                      <excludes>
                        <exclude>**/test/generated/**</exclude>
                      </excludes>
    ``` 
    
    The above comment is optional.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message