drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication
Date Fri, 06 Jan 2017 01:33:34 GMT
Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/578#discussion_r94849762
  
    --- Diff: protocol/src/main/protobuf/User.proto ---
    @@ -111,6 +115,21 @@ message BitToUserHandshake {
       optional string errorId = 4;
       optional string errorMessage = 5;
       optional RpcEndpointInfos server_infos = 6;
    +  repeated string authenticationMechanisms = 7;
    --- End diff --
    
    shouldn't this be optional ? I am not sure when new server builds this message and send
back to older client then how this field is ignored on client side without being optional.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message