drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication
Date Fri, 06 Jan 2017 01:33:34 GMT
Github user sohami commented on a diff in the pull request:

    --- Diff: contrib/native/client/src/clientlib/drillClientImpl.hpp ---
    @@ -522,6 +534,13 @@ class DrillClientImpl : public DrillClientImplBase{
             exec::user::RpcEndpointInfos m_serverInfos;
             bool m_bIsConnected;
    +        std::vector<std::string> m_mechanisms;
    --- End diff --
    Please change it to be "m_supportedMechanisms" as in Java client or "m_serverMechanisms"
since these are list of mechanisms supported by server not client.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message