drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #719: DRILL-5172: Display elapsed time for queries in the...
Date Thu, 05 Jan 2017 22:01:40 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/719#discussion_r94860581
  
    --- Diff: exec/java-exec/src/main/resources/rest/profile/list.ftl ---
    @@ -64,6 +65,8 @@
                 <td>
                   <div style="height:100%;width:100%">${query.getState()}</div>
         
                 <td>
    +              <div style="height:100%;width:100%">${(.now?long - query.getStartTime())
/ 1000} sec</div>          
    --- End diff --
    
    Rounding? Should 999 ms be shown as 0 seconds or 1 second. Actually, given the short duration
of some queries, should the time be shown down to the ms? That is either 1234 ms or 1.234
sec. Or, we could be fancy and show only three digits of precision: 1.23 seconds, 123,000
seconds. Further, do we want to shift units as the numbers increase: 234 ms, 23.4 seconds,
15 min 34 sec. 1 hr 23 min.?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message