drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #719: DRILL-5172: Display elapsed time for queries in the...
Date Thu, 05 Jan 2017 22:01:40 GMT
Github user paul-rogers commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
    @@ -106,7 +106,13 @@
       <p>STATE: ${model.getProfile().getState().name()}</p>
       <p>FOREMAN: ${model.getProfile().getForeman().getAddress()}</p>
       <p>TOTAL FRAGMENTS: ${model.getProfile().getTotalFragments()}</p>
    +  <p>
    +  <#if (model.getProfile().getState().name() == "RUNNING")> 
    +    ELAPSED: ${(.now?long - model.getProfile().getStart()) / 1000} 
    --- End diff --
    Rather than encoding this in the template three times, perhaps compute it ahead of time
and store the computed result in the "model". Makes it easier to handle the multi-unit formatting,
digits of precision, etc.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message