drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #716: DRILL-5116: Enable generated code debugging in each...
Date Thu, 05 Jan 2017 03:48:15 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/716#discussion_r94697603
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassCompilerSelector.java
---
    @@ -119,13 +119,18 @@ public ClassCompilerSelector(ClassLoader classLoader, DrillConfig
config, Option
         byte[][] bc = getCompiler(sourceCode).getClassByteCode(className, sourceCode);
     
         // Uncomment the following to save the generated byte codes.
    -
    -//    final String baseDir = System.getProperty("java.io.tmpdir") + File.separator +
className;
    -//    File classFile = new File(baseDir + className.clazz);
    -//    classFile.getParentFile().mkdirs();
    -//    try (BufferedOutputStream out = new BufferedOutputStream(new FileOutputStream(classFile)))
{
    -//      out.write(bc[0]);
    +    // Use the JDK javap command to view the generated code.
    +    // This is the code from the compiler before byte code manipulations.
    --- End diff --
    
    Maybe add a comment that for the "after BC manipulations" see similar code in  QueryClassLoader.java
.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message