drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chunhui-shi <...@git.apache.org>
Subject [GitHub] drill pull request #609: DRILL-4882 - Support for MongoDB Direct Connection ...
Date Wed, 04 Jan 2017 23:24:00 GMT
Github user chunhui-shi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/609#discussion_r94687060
  
    --- Diff: contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoStoragePlugin.java
---
    @@ -136,17 +138,40 @@ public synchronized MongoClient getClient(List<ServerAddress>
addresses) {
         if (client == null) {
           if (credential != null) {
             List<MongoCredential> credentialList = Arrays.asList(credential);
    -        client = new MongoClient(addresses, credentialList, clientURI.getOptions());
    +        if (!isDirectConnection()) {
    --- End diff --
    
    Could you add Unit test for this fix?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message