Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: spanchamiamapr <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-700-drill@git.apache.org>
In-Reply-To: <git-pr-700-drill@git.apache.org>
Subject: [GitHub] drill pull request #700: DRILL-5137 - Optimize count(*) queries on MapR-DB B...
Content-Type: text/plain
Message-Id: <20161222230301.62199DFCC0@git1-us-west.apache.org>
Date: Thu, 22 Dec 2016 23:03:01 +0000 (UTC)
archived-at: Thu, 22 Dec 2016 23:03:03 -0000

Github user spanchamiamapr commented on a diff in the pull request:

    https://github.com/apache/drill/pull/700#discussion_r93710708
  
    --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java ---
    @@ -124,6 +124,11 @@ public HBaseRecordReader(Connection connection, HBaseSubScan.HBaseSubScanSpec su
         } else {
           rowKeyOnly = false;
           transformed.add(ROW_KEY_PATH);
    +      /* DRILL-5137 - optimize count(*) queries on MapR-DB Binary tables */
    +      if (isSkipQuery()) {
    --- End diff --
    
    I thought of this, however I got stuck because there is no vectorContainerWriter in HBaseRecordReader class. If you can send a diff of how to do this, I can include that too. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---