Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: arina-ielchiieva <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-685-drill@git.apache.org>
In-Reply-To: <git-pr-685-drill@git.apache.org>
Subject: [GitHub] drill pull request #685: Drill 5043: Function that returns a unique id per s...
Content-Type: text/plain
Message-Id: <20161220103317.9A0F0DFC4F@git1-us-west.apache.org>
Date: Tue, 20 Dec 2016 10:33:17 +0000 (UTC)
archived-at: Tue, 20 Dec 2016 10:33:21 -0000

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/685#discussion_r93209088
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
    @@ -343,10 +346,10 @@ public BitToUserHandshake getHandshakeResponse(UserToBitHandshake inbound) throw
               if (inbound.getRpcVersion() != UserRpcConfig.RPC_VERSION) {
                 final String errMsg = String.format("Invalid rpc version. Expected %d, actual %d.",
                     UserRpcConfig.RPC_VERSION, inbound.getRpcVersion());
    -
                 return handleFailure(respBuilder, HandshakeStatus.RPC_VERSION_MISMATCH, errMsg, null);
               }
     
    +          Map<String, String> sessionParams = new LinkedHashMap<String, String>();
    --- End diff --
    
    May be it's better to keep setUser method as is, I don't really like the idea of creating empty map each time we getHandshakeResponce


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---