Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: arina-ielchiieva <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-666-drill@git.apache.org>
In-Reply-To: <git-pr-666-drill@git.apache.org>
Subject: [GitHub] drill pull request #666: DRILL-4956: Temporary tables support
Content-Type: text/plain
Message-Id: <20161219150500.B107BDFBAF@git1-us-west.apache.org>
Date: Mon, 19 Dec 2016 15:05:00 +0000 (UTC)
archived-at: Mon, 19 Dec 2016 15:05:04 -0000

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/666#discussion_r91952394
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
    @@ -55,13 +61,37 @@
       private OptionManager sessionOptions;
       private final AtomicInteger queryCount;
     
    +  /** Unique session identifier used as suffix in temporary table names. */
    +  private final String uuid;
    +  /** Cache that stores all temporary tables by schema names. */
    +  private final TemporaryTablesCache temporaryTablesCache;
    +
    +  /** On session close drops all temporary tables from their schemas and clears temporary tables cache. */
    +  @Override
    +  public void close() {
    +    temporaryTablesCache.removeAll(new BiConsumer<AbstractSchema, String>() {
    +      @Override
    +      public void accept(AbstractSchema schema, String tableName) {
    +        try {
    +          if (schema.isAccessible() && schema.getTable(tableName) != null) {
    +            schema.dropTable(tableName);
    +            logger.info("Temporary table [{}] was dropped from schema [{}]", tableName, schema.getFullSchemaName());
    +          }
    +        } catch (Exception e) {
    +          logger.info("Problem during temporary table [{}] drop from schema [{}]",
    --- End diff --
    
    Such syntax was used before so I decided not to change it, for example, check TestCTAS.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---