Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1A977200BD3 for ; Tue, 6 Dec 2016 20:28:38 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 179CB160B1B; Tue, 6 Dec 2016 19:28:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 57CA4160B17 for ; Tue, 6 Dec 2016 20:28:37 +0100 (CET) Received: (qmail 99696 invoked by uid 500); 6 Dec 2016 19:28:36 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 99685 invoked by uid 99); 6 Dec 2016 19:28:36 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Dec 2016 19:28:36 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 20BDCE0159; Tue, 6 Dec 2016 19:28:36 +0000 (UTC) From: chunhui-shi To: dev@drill.apache.org Reply-To: dev@drill.apache.org References: In-Reply-To: Subject: [GitHub] drill pull request #654: DRILL-5032: Drill query on hive parquet table faile... Content-Type: text/plain Message-Id: <20161206192836.20BDCE0159@git1-us-west.apache.org> Date: Tue, 6 Dec 2016 19:28:36 +0000 (UTC) archived-at: Tue, 06 Dec 2016 19:28:38 -0000 Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/654#discussion_r91153138 --- Diff: contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/schema/TestColumnListCache.java --- @@ -0,0 +1,78 @@ +/* --- End diff -- Could you add a unit test to verify when there are two kind (or more) of columns in e.g. 10 partitions, the physical plan text has only two copies of columns? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---