drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #709: DRILL-5156: BootStrapContext should close threads
Date Wed, 28 Dec 2016 05:54:31 GMT
GitHub user paul-rogers opened a pull request:

    https://github.com/apache/drill/pull/709

    DRILL-5156: BootStrapContext should close threads

    The Bit-Client thread (that's the thread name) finds a closed allocator in TestDrillbitResilience
unit test. This fix (along with DRILL-5157) eliminates two run-time problems seen in this
unit tests.
    
    BootStrapContext creates two thread pools, but does not close them. This allows the code
running in the threads to attempt to access their allocators after the allocator is closed.
This fix ensures that the
    thread pools are closed to avoid the issue.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paul-rogers/drill DRILL-5156

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/709.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #709
    
----
commit 73607c33c78dd89373412c8e4c70356fa19f81fd
Author: Paul Rogers <progers@maprtech.com>
Date:   2016-12-28T01:45:16Z

    DRILL-5156: BootStrapContext should close threads
    
    Bit-Client thread finds closed allocator in TestDrillbitResilience unit
    test. This fix (along with DRILL-5157) eliminates two run-time problems
    seen in this unit tests.
    
    BootStrapContext creates two thread pools, but does not close them.
    This allows the code running in the threads to attempt to access their
    allocators after the allocator is closed. This fix ensures that the
    thread pools are closed to avoid the issue.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message