drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #693: DRILL-5122: DrillBuf performs expensive logging if ...
Date Tue, 13 Dec 2016 01:04:52 GMT
GitHub user paul-rogers opened a pull request:

    https://github.com/apache/drill/pull/693

    DRILL-5122: DrillBuf performs expensive logging if -ea set

    In Drill, once assertions are enabled, the dominant cost of a query
    becomes DrillBuf logging. One example showed that DrillBuf logging
    increases query cost by 10x.
    
    Logging was enabled by the -ea option, which should be available for
    many other uses. Changed to require a specific option to be turned on.
    
    Enabled the option for memory tests (which require the option) but off
    by default and for all other tests.
    
    To do this, converted Surefire system options from command line args to
    system variables so that they can be customized in sub-project poms.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paul-rogers/drill DRILL-5122

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/693.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #693
    
----
commit 25aa8ea844555806608f1a1e9c30202455219efa
Author: Paul Rogers <progers@maprtech.com>
Date:   2016-12-12T22:42:07Z

    DRILL-5122: DrillBuf performs expensive logging if -ea set
    
    In Drill, once assertions are enabled, the dominant cost of a query
    becomes DrillBuf logging. One example showed that DrillBuf logging
    increases query cost by 10x.
    
    Logging was enabled by the -ea option, which should be available for
    many other uses. Changed to require a specific option to be turned on.
    
    Enabled the option for memory tests (which require the option) but off
    by default and for all other tests.
    
    To do this, converted Surefire system options from command line args to
    system variables so that they can be customized in sub-project poms.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message