drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdiravka <...@git.apache.org>
Subject [GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...
Date Tue, 27 Dec 2016 15:08:12 GMT
Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/520#discussion_r93939395
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java
---
    @@ -241,6 +244,10 @@ public long getInSubqueryThreshold() {
         return options.getOption(IN_SUBQUERY_THRESHOLD);
       }
     
    +  public boolean isAnsiQuotesEnabled() {
    --- End diff --
    
    For this reason maybe it makes sense to implement not boolean option ANSI_QUOTES, but
some string option, to turn on necessary lexical policy.  
    I raised this question in jira [DRILL-3510](https://issues.apache.org/jira/browse/DRILL-3510?focusedCommentId=15780561&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15780561)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message