drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #703: DRILL-5104: Foreman should not set sort memory for ...
Date Thu, 22 Dec 2016 02:36:25 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    --- Diff: logical/src/main/java/org/apache/drill/common/logical/PlanProperties.java ---
    @@ -112,8 +121,13 @@ public PlanPropertiesBuilder generator(Generator generator) {
           return this;
    +    public PlanPropertiesBuilder generator(boolean hasResourcePlan) {
    --- End diff --
    The method's name should not be **generator** but something about having a resource plan

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message