drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #685: Drill 5043: Function that returns a unique id per s...
Date Tue, 20 Dec 2016 10:33:17 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/685#discussion_r93206705
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java
---
    @@ -97,6 +101,14 @@ public Builder withUserProperties(UserProperties properties) {
           return this;
         }
     
    +    public Builder setSessionContextInfo(Map<String, String> sessionParams) {
    +        UserSessionContextInformation.Builder sessionContextBuilder = UserSessionContextInformation.newBuilder()
    +            .setSessionId(userSession.sessionId);
    +        // TODO: Populate sessionParams into UserSesessionContextInfo
    +        userSession.sessionContextInfo =  sessionContextBuilder.build();
    +        return this;
    +    }
    --- End diff --
    
    I guess UserSessionContextInformation should exist disregarding calling setSessionContextInfo.
setSessionContextInfo needs to enrich it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message