drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #685: Drill 5043: Function that returns a unique id per s...
Date Tue, 20 Dec 2016 10:33:17 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/685#discussion_r93206188
  
    --- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
    @@ -320,3 +320,17 @@ message Jar {
       repeated string function_signature = 2;
     }
     
    +
    +/* Session parameter
    +message SessionParam {
    +  optional string key = 1;
    +  optional string value = 2;
    +}
    --- End diff --
    
    We have similar Property in User.proto, not sure we need to create new message with the
same content.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message