drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...
Date Mon, 19 Dec 2016 22:33:26 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/660#discussion_r93134337
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/JaninoClassCompiler.java
---
    @@ -58,5 +56,27 @@ public JaninoClassCompiler(ClassLoader parentClassLoader, boolean debug)
{
       }
     
       @Override
    +  public Map<String,byte[]> compile(final ClassNames className, final String sourceCode)
    +      throws CompileException, IOException, ClassNotFoundException {
    +
    +    ClassFile[] classFiles = doCompile(sourceCode);
    +    Map<String,byte[]> results = new HashMap<>();
    +    for(int i = 0;  i < classFiles.length;  i++) {
    +      ClassFile classFile = classFiles[i];
    +      results.put(classFile.getThisClassName(), classFile.toByteArray());
    --- End diff --
    
    As we've discussed, this is the class loader, not the global class cache. The non-ASM
path can't get the class name from the byte codes, so the compiler has to tell us, via this
map, which byte code corresponds to which compiled class name. The "plain old Java" class
loader then fetches classes given their compiled names using this map.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message