drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nagarajanchinnasamy <...@git.apache.org>
Subject [GitHub] drill issue #685: Drill 5043: Function that returns a unique id per session/...
Date Mon, 19 Dec 2016 07:23:03 GMT
Github user nagarajanchinnasamy commented on the issue:

    https://github.com/apache/drill/pull/685
  
    @arina-ielchiieva Sorry for the refactoring before consulting some of the thoughts I had.
Thanks for the suggestion to add such changes in separate commit. Learning the process :)
    
    1. Idea of having UserSessionContext as a separate class was to have the ability to hold
additional session related parameters as a possible future extension. Basically have the ability
to:
      - populate system captured session parameters
      - have custom authenticator populated session parameters
    
    2. I agree to the point that session-id cannot be optional.
    
    I will see how I can combine above points and submit another commit. Hope that's fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message