drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #686: DRILL-5117: Compile error when query a json file wi...
Date Tue, 13 Dec 2016 23:39:43 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/686#discussion_r92292702
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/compile/TestLargeFileCompilation.java
---
    @@ -154,4 +158,20 @@ public void testProject() throws Exception {
         testNoResult(ITERATION_COUNT, LARGE_QUERY_SELECT_LIST);
       }
     
    +  @Test
    +  public void testSelectAllFromFileWithManyColumns() throws Exception {
    +    File path = new File(BaseTestQuery.getTempDir("json/input"));
    --- End diff --
    
    You do not have to generate a new json file for writing a unit test. Not sure how the
new created file is cleaned up if the testcase failed.
    
    You may consider using the existing tpch sample file to do unit test, or re-enable the
originally ignored test (testTOP_N_SORT).
    
    ```java
      @Test
      public void testLargeListColWithLimit() throws Exception {
        final int nCol = 1000;
        final StringBuilder sb = new StringBuilder();
    
        sb.append(" select n_nationkey ");
        for (int i = 0; i< nCol; i++) {
          sb.append(", " + "Col" + i );
        }
        sb.append(" from cp.`tpch/nation.parquet`");
        sb.append(" limit 1");
    
        test(sb.toString());
      }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message