drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #685: Drill 5043: Function that returns a unique id per s...
Date Mon, 12 Dec 2016 08:40:05 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/685#discussion_r91901654
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/Utilities.java ---
    @@ -43,19 +43,21 @@ public static String getFileNameForQueryFragment(FragmentContext context,
String
       }
     
       /**
    -   * Create QueryContextInformation with given <i>defaultSchemaName</i>.
Rest of the members of the
    +   * Create QueryContextInformation with given <i>defaultSchemaName</i> and
<i>sessionId</i>. Rest of the members of the
        * QueryContextInformation is derived from the current state of the process.
        *
        * @param defaultSchemaName
    +   * @param sessionId
        * @return
        */
    --- End diff --
    
    Please add description for two @param and return, since you are changing method description.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message