drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #676: DRILL-5091: JDBC unit test fail on Java 8
Date Fri, 09 Dec 2016 21:20:41 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/676#discussion_r91797180
  
    --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseThrowExceptionsTest.java
---
    @@ -477,18 +468,32 @@ public void testClosedConnectionMethodsThrowRight() {
         }
     
         @Override
    +    protected boolean isOkayNonthrowingMethod(Method method) {
    +      // Java 8 method
    +      if ("getLargeUpdateCount".equals(method.getName())) {
    +        return true; }
    +      return super.isOkayNonthrowingMethod(method);
    +    }
    +
    +    @Override
         protected boolean isOkaySpecialCaseException(Method method, Throwable cause) {
           final boolean result;
           if (super.isOkaySpecialCaseException(method, cause)) {
             result = true;
           }
    +      else if (   method.getName().equals("executeLargeBatch")
    +               || method.getName().equals("executeLargeUpdate")) {
    +        // New Java 8 methods not implemented in Avatica.
    --- End diff --
    
    Please open a ticket for this, so we make changes once Avatica supports Java 8, add TODOs
instead of comments for easy tracking ([example](https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java#L103)).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message