drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nagarajanchinnasamy <...@git.apache.org>
Subject [GitHub] drill pull request #685: Drill 5043: Function that returns a unique id per s...
Date Fri, 09 Dec 2016 09:48:56 GMT
Github user nagarajanchinnasamy commented on a diff in the pull request:

    https://github.com/apache/drill/pull/685#discussion_r91685705
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java
---
    @@ -115,6 +118,7 @@ public UserSession build() {
     
       private UserSession() {
         queryCount = new AtomicInteger(0);
    +    sessionId = nextSessionId.getAndIncrement();
       }
    --- End diff --
    
    Yes. This approach doesn't take distribution in consideration. Looking for inputs on what
should be the approach for distributed environment. As suggested by @paul-rogers I will look
into #666 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message