drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...
Date Fri, 09 Dec 2016 04:36:26 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/660#discussion_r91641345
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java
---
    @@ -246,6 +246,12 @@ public void rotateBlock() {
         rotateBlock(BlkCreateMode.TRUE);
       }
     
    +  /**
    +   * Create a new code block, closing the current block.
    +   *
    +   * @param mode
    +   */
    --- End diff --
    
    Oh? Do you use IntelliJ? Eclipse generates these items, but does not complain about them.
Since I've been cleaning up the yellow warnings that appear in Eclipse, I should not create
new ones for IntelliJ... Or if Eclipse, what setting did you turn on to get the warnings?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message