drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...
Date Fri, 09 Dec 2016 04:36:06 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/660#discussion_r91640219
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/MergeAdapter.java
---
    @@ -253,7 +257,13 @@ public static MergedClassResult getMergedClass(final ClassSet set,
final byte[]
           }
     
           // enable when you want all the generated merged class files to also be written
to disk.
    -//      Files.write(outputClass, new File(String.format("/src/scratch/drill-generated-classes/%s-output.class",
set.generated.dot)));
    +//      try {
    --- End diff --
    
    Bulk writing of class source code would not likely be useful. Just left this in place
from the previous code, but fixed it so it would work if uncommented. Actually, once this
PR is in, the need to do this trick will disappear and we can simply remove this code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message