drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #660: DRILL-5052: Option to debug generated Java code usi...
Date Thu, 08 Dec 2016 15:26:54 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/660#discussion_r91511795
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/JaninoClassCompiler.java
---
    @@ -58,5 +56,27 @@ public JaninoClassCompiler(ClassLoader parentClassLoader, boolean debug)
{
       }
     
       @Override
    +  public Map<String,byte[]> compile(final ClassNames className, final String sourceCode)
    +      throws CompileException, IOException, ClassNotFoundException {
    +
    +    ClassFile[] classFiles = doCompile( className, sourceCode );
    +    Map<String,byte[]> results = new HashMap<>( );
    --- End diff --
    
    I've noticed that mostly in Drill Guava lib is used for collection creation: Maps.newHashMap();


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message