drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #685: Drill 5043: Function that returns a unique id per s...
Date Thu, 08 Dec 2016 13:43:58 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/685#discussion_r91515498
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java
---
    @@ -115,6 +118,7 @@ public UserSession build() {
     
       private UserSession() {
         queryCount = new AtomicInteger(0);
    +    sessionId = nextSessionId.getAndIncrement();
       }
    --- End diff --
    
    As far as I know, UserSession instance is created for each session, won't this mean that
after your changes each session will have the same id? Actually CTTAS are going to add session
id in its scope (it's represented as String and generated using UUID). You make take a look
at those changes - https://github.com/apache/drill/pull/666


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message