drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #676: DRILL-5091: JDBC unit test fail on Java 8
Date Thu, 08 Dec 2016 02:05:45 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/676#discussion_r91426330
  
    --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseThrowExceptionsTest.java
---
    @@ -477,18 +477,32 @@ public void testClosedConnectionMethodsThrowRight() {
         }
     
         @Override
    +    protected boolean isOkayNonthrowingMethod(Method method) {
    +      // Java 8 method
    +      if ( "getLargeUpdateCount".equals(method.getName())) {
    +        return true; }
    +      return super.isOkayNonthrowingMethod(method);
    +    }
    +
    +    @Override
         protected boolean isOkaySpecialCaseException(Method method, Throwable cause) {
           final boolean result;
           if (super.isOkaySpecialCaseException(method, cause)) {
             result = true;
           }
    +      else if (   method.getName().equals("executeLargeBatch")
    --- End diff --
    
    This one stays... The style in this file was to align the terms in the conditional. Following
a pattern established elsewhere in the file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message