drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #676: DRILL-5091: JDBC unit test fail on Java 8
Date Thu, 08 Dec 2016 02:05:45 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/676#discussion_r91429339
  
    --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcAssert.java ---
    @@ -66,6 +66,11 @@ public static void setFactory(ConnectionFactory factory) {
       public static Properties getDefaultProperties() {
         final Properties properties = new Properties();
         properties.setProperty("drillJDBCUnitTests", "true");
    +
    +    // Must set this to false to ensure that the tests ignore any existing
    +    // plugin configurations stored in /tmp/drill.
    +
    --- End diff --
    
    I prefer extra lines around comments. Makes the flow less cluttered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message