drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ppadma <...@git.apache.org>
Subject [GitHub] drill pull request #676: DRILL-5091: JDBC unit test fail on Java 8
Date Thu, 08 Dec 2016 01:06:26 GMT
Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/676#discussion_r91422697
  
    --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2769UnsupportedReportsUseSqlExceptionTest.java
---
    @@ -368,10 +381,19 @@ public void testConnectionMethodsThrowRight() {
           this.factoryConnection = factoryConnection;
         }
     
    +    @Override
         protected Statement getJdbcObject() throws SQLException {
           return factoryConnection.createStatement();
         }
     
    +    @Override
    +    protected boolean isOkaySpecialCaseException(Method method,
    +                                                 Throwable cause) {
    +       // New Java 8 method not supported by Avatica
    +
    --- End diff --
    
    remove the extra line


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message