drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #665: DRILL-5056: UserException does not write full messa...
Date Wed, 07 Dec 2016 01:26:47 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/665#discussion_r91210473
  
    --- Diff: common/src/main/java/org/apache/drill/common/exceptions/UserException.java ---
    @@ -549,7 +550,12 @@ public UserException build(final Logger logger) {
           if (isSystemError) {
             logger.error(newException.getMessage(), newException);
           } else {
    -        logger.info("User Error Occurred", newException);
    +        String msg = "User Error Occurred";
    +        if (message != null) {
    +          msg += ": " + message; }
    +        if (cause != null) {
    --- End diff --
    
    The whole stack trace appears in the log. The item above is for those "helpful" users
go just do a grep based on the query ID and find just the lines with the log header (including
query ID.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message