drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #665: DRILL-5056: UserException does not write full messa...
Date Tue, 06 Dec 2016 19:58:11 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/665#discussion_r91158494
  
    --- Diff: common/src/main/java/org/apache/drill/common/exceptions/UserException.java ---
    @@ -549,7 +550,12 @@ public UserException build(final Logger logger) {
           if (isSystemError) {
             logger.error(newException.getMessage(), newException);
           } else {
    -        logger.info("User Error Occurred", newException);
    +        String msg = "User Error Occurred";
    +        if (message != null) {
    +          msg += ": " + message; }
    +        if (cause != null) {
    --- End diff --
    
    Wonder if the root cause (see line 540 above) may also be useful (in case it is below/different
from 'cause') ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message