drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #672: DRILL-5085: Add / update description for dynamic UD...
Date Tue, 06 Dec 2016 14:47:14 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/672#discussion_r91085531
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -45,11 +45,13 @@ drill.client: {
       supports-complex-types: true
     }
     
    -// Directory is used as base for temporary storage of Dynamic UDF jars.
    -// Set this property if you want to have custom temporary directory, instead of generated
at runtime.
    -// By default ${DRILL_TMP_DIR} is used if set.
    -// drill.tmp-dir: "/tmp"
    -// drill.tmp-dir: ${?DRILL_TMP_DIR}
    +// Location Drill uses for temporary files, such as downloaded dynamic UDFs jars.
    --- End diff --
    
    1. Reverted generated directory logic.
    2. "/tmp/drill/udf" + cluster-id is not good idea, since local udf directory has similar
location as remote. And remote directory is generated as cluster-id + /udf. So I suggest to
keep it as is. Local registry is returned to use its previous composition logic.
    3. Removed "cluster-temp-dir", we don't need it for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message