drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #666: DRILL-4956: Temporary tables support
Date Tue, 06 Dec 2016 06:12:56 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/666#discussion_r91015099
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaConfig.java ---
    @@ -94,12 +94,16 @@ public ViewExpansionContext getViewExpansionContext() {
         return provider.getViewExpansionContext();
       }
     
    +  public String getUuid() { return provider.getUuid(); }
    +
       /**
        * Interface to implement to provide required info for {@link org.apache.drill.exec.store.SchemaConfig}
        */
       public interface SchemaConfigInfoProvider {
         ViewExpansionContext getViewExpansionContext();
     
         OptionValue getOption(String optionKey);
    +
    +    String getUuid();
    --- End diff --
    
    getSessionId ?
    (The reason, by the way, is that uuid is a type and we usually don't do getInt() or getString()
but instead say getAge(), getName()...)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message