drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #666: DRILL-4956: Temporary tables support
Date Tue, 06 Dec 2016 06:12:51 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/666#discussion_r91016215
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
    @@ -523,7 +541,7 @@ public Table getTable(String tableName) {
             logger.debug("The filesystem for this workspace does not support this operation.",
e);
           }
     
    -      return tables.get(tableKey);
    +      return tables.get(temporaryTableKey) == null ? tables.get(tableKey) : tables.get(temporaryTableKey);
    --- End diff --
    
    Not a big deal, but requires double lookup.
    
    ```
    Table t = tables.get(temporaryTableKey);
    return t != null ? t : tables.get(tableKey)
    ```
    
    This function, BTW, cries our for refactoring. But, that is another project...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message