drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From parthchandra <...@git.apache.org>
Subject [GitHub] drill pull request #673: DRILL-4764: Parquet file with INT_16, etc. logical ...
Date Fri, 02 Dec 2016 18:34:19 GMT
Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/673#discussion_r90694935
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetFixedWidthDictionaryReaders.java
---
    @@ -56,6 +58,31 @@ protected void readField(long recordsToReadInThisPass) {
         }
    --- End diff --
    
    What about NullableDictionaryUint types?
    Also, It is probably a good idea to create a single parquet file with columns of all combinations
of these types, 
    Nullable, dictionary encoded, signed and unsigned int2, int4, int8 types and a single
unit test to read that file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message