drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #672: DRILL-5085: Add / update description for dynamic UD...
Date Fri, 02 Dec 2016 18:01:21 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/672#discussion_r90689224
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -45,11 +45,13 @@ drill.client: {
       supports-complex-types: true
     }
     
    -// Directory is used as base for temporary storage of Dynamic UDF jars.
    -// Set this property if you want to have custom temporary directory, instead of generated
at runtime.
    -// By default ${DRILL_TMP_DIR} is used if set.
    -// drill.tmp-dir: "/tmp"
    -// drill.tmp-dir: ${?DRILL_TMP_DIR}
    +// Location Drill uses for temporary files, such as downloaded dynamic UDFs jars.
    --- End diff --
    
    Can we leave it that, if blank, it will use the system-generated directory as you have
in 1.9? This means we'll still need your getTmpDir method. To do the check for blank.
    
    Also, as it turns out, we already have a temp dir setting used elsewhere. Look in drill-override-example.conf
under drill.sys.store.provider.local.path. It uses "/tmp/drill". Then it adds subdirs for
storage plugins and what-not.
    
    Can we use "/tmp/drill/udf" as the base temp storage location for udfs to be consistent?
Then we'd add the cluster-id, etc. as in your "cluster-temp-dir" below.
    
    And, yes, we have lots of places where we specify the temp file system (UDFs, the one
cited above, the (unused) cache.hazel, the temp dirs for spilling, ...). We do need to create
a project (later) to rationalize all of this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message