drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #675: DRILL-5094: Comparator should guarantee transitive ...
Date Fri, 02 Dec 2016 17:58:05 GMT
Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/675#discussion_r90688989
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/AssignmentCreator.java
---
    @@ -50,7 +50,8 @@
       private static Comparator<Entry<DrillbitEndpoint,Long>> comparator = new
Comparator<Entry<DrillbitEndpoint,Long>>() {
         @Override
         public int compare(Entry<DrillbitEndpoint, Long> o1, Entry<DrillbitEndpoint,Long>
o2) {
    -      return (int) (o1.getValue() - o2.getValue());
    +      long ret = o1.getValue() - o2.getValue();
    --- End diff --
    
    Alternatively: 
    `
    return o1.getValue().compareTo(o2.getValue());
    `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message